Easier debugging for functional tests#3021
Closed
Pierre-Sassoulas wants to merge 9 commits intopylint-dev:masterfrom
Closed
Easier debugging for functional tests#3021Pierre-Sassoulas wants to merge 9 commits intopylint-dev:masterfrom
Pierre-Sassoulas wants to merge 9 commits intopylint-dev:masterfrom
Conversation
83a2be0 to
004bae0
Compare
20efeca to
6447b37
Compare
Easier debugging of the tests.
Permit to place the functional tests wherever we want.
…nctional_tests.py Permit to navigate in the functional tests easier.
Or we get a "module does not exists".
6447b37 to
f4f34bd
Compare
Member
Author
|
@PCManticore #2036 is based on this one, this is not absolutely necessary for it to work, but I would appreciate to not have to rewrite the commit tree :) |
AWhetter
approved these changes
Sep 7, 2019
Contributor
AWhetter
left a comment
There was a problem hiding this comment.
This has bugged me for a while. Seems like a good change to me!
AWhetter
approved these changes
Sep 7, 2019
Contributor
AWhetter
left a comment
There was a problem hiding this comment.
This has bugged me for a while. Seems like a worthwhile change to me!
Contributor
|
This is awesome! 😄 Thank you for tackling it @Pierre-Sassoulas Merged it manually to get rid of the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This merge request permits to :
NoFileErroris launched.FunctionalTest:test_nameinstead of<functional test object hexhash>.Previously :
With this merge request :
tests/functionalby usingos.walkinstead ofos.listdir. There were hundreds of files all in the same directory and it was beginning to be hard to navigate. Now you can put any tests in any directory insidetests/functional.tests/functional/example_tests.py=>tests/functional/e/example_test.py. For functional test starting withtoomove them in atests/functional/toodirectory so developers are aware it's a possibility and there aren't any magic going on forcing you to use the one letter directory approach.Type of Changes